Drop cty dependency now that core::ffi has that covered #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the types re-exported from there are aliases to the native types (i8 etc) and not newtypes, they can compatibly be replaced with their now-stdlib definitions.
Now that a recent change made 1.64 mandatory, this can just as well be done now.
|
Seems like the type drama in the tests was "just" caused by having some dependencies not updated (falling back to older versions). There might still be flip-flopping (cty on ARM has c_char = u8, core::ffi has c_char = i8), but given that all Rust code must support either already anyway, maybe it's not even a breaking change in some sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that this introduces yet another round of "signed vs unsigned char" errors on ARM architectures, this probably needs to sit and wait for a large breaking change. It's probably worth just biting through that once...